Review Request: Allow to get and set max size of pixmap cache from KImageCache

[Michael Pyne]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5377/#review7798
-----------------------------------------------------------



trunk/KDE/kdelibs/kdeui/util/kimagecache.h
<http://svn.reviewboard.kde.org/r/5377/#comment7985>

    You should specific units used for memory (i.e. highest memory size in bytes)



trunk/KDE/kdelibs/kdeui/util/kimagecache.h
<http://svn.reviewboard.kde.org/r/5377/#comment7984>

    This needs a @since 4.6 (and to be clear, this cannot get backported to 4.5, although it's good that it runs there too ;)



trunk/KDE/kdelibs/kdeui/util/kimagecache.h
<http://svn.reviewboard.kde.org/r/5377/#comment7986>

    @since 4.6 here too.



trunk/KDE/kdelibs/kdeui/util/kimagecache.cpp
<http://svn.reviewboard.kde.org/r/5377/#comment7989>

    Please use /8 here instead of /10. It gives slightly more memory by default, and it is a power of 2.
    
    You should add spaces around the / operator as well (i.e. defaultCacheSize / 8)
    
    Also, given that we're dividing you should use qMax() to ensure that the pixmap cache's maxCost has a minimum (perhaps 16 KiB).


- Michael


On 2010-09-22 07:51:22, Manuel Mommertz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5377/
> -----------------------------------------------------------
> 
> (Updated 2010-09-22 07:51:22)
> 
> 
> Review request for kdelibs and Michael Pyne.
> 
> 
> Summary
> -------
> 
> Set a reasonable maximum size for the pixmap cache and allow to get and set this size.
> 
> For now the pixmap cache gets a maximum size of 10% from the shared data cache on disk. Is this a good value or should it be something different?
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kdeui/util/kimagecache.h 1178059 
>   trunk/KDE/kdelibs/kdeui/util/kimagecache.cpp 1178059 
> 
> Diff: http://svn.reviewboard.kde.org/r/5377/diff
> 
> 
> Testing
> -------
> 
> I use 4.5 branche with this patch applied for daily work. No Problems so far.
> 
> 
> Thanks,
> 
> Manuel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100925/b7a8bbe1/attachment.htm>