Review Request: Cleanup KLed

Christoph Feck christoph at
Fri Sep 17 13:03:52 BST 2010

This is an automatically generated e-mail. To reply, visit:

(Updated 2010-09-17 12:03:51.864345)

Review request for kdelibs.


Fix regression: Do not render square when shape is Rectangular.

Thanks Pedro for noticing.


* massive code reduction by using Qt gradients
* fix background, now uses transparency
* fix cache not updated on look changes
* fix cropped appearance
* simplify cachedPixmap handling
* use SmallIconSize as sizeHint
* remove "builtin" benchmark

I would like to get feedback on the changed rendering of rectangular LEDs.

This addresses bug 98719.

Diffs (updated)

  /trunk/KDE/kdelibs/kdeui/widgets/kled.h 1176221 
  /trunk/KDE/kdelibs/kdeui/widgets/kled.cpp 1176221 



Screenshots (updated)

OLD appearance
r1 appearance
r3 appearance



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list