Review Request: Cleanup KLed
Todd
toddrme2178 at gmail.com
Fri Sep 17 07:14:28 BST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5369/#review7652
-----------------------------------------------------------
Wow, that looks really good!
- Todd
On 2010-09-17 05:18:58, Christoph Feck wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5369/
> -----------------------------------------------------------
>
> (Updated 2010-09-17 05:18:58)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> * massive code reduction by using Qt gradients
> * fix background, now uses transparency
> * fix cache not updated on look changes
> * fix cropped appearance
> * simplify cachedPixmap handling
> * use SmallIconSize as sizeHint
> * remove "builtin" benchmark
>
> I would like to get feedback on the changed rendering of rectangular LEDs.
>
>
> This addresses bug 98719.
> https://bugs.kde.org/show_bug.cgi?id=98719
>
>
> Diffs
> -----
>
> /trunk/KDE/kdelibs/kdeui/widgets/kled.h 1176221
> /trunk/KDE/kdelibs/kdeui/widgets/kled.cpp 1176221
>
> Diff: http://svn.reviewboard.kde.org/r/5369/diff
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> OLD appearance
> http://svn.reviewboard.kde.org/r/5369/s/505/
> NEW appearance
> http://svn.reviewboard.kde.org/r/5369/s/506/
> r2 appearance
> http://svn.reviewboard.kde.org/r/5369/s/507/
>
>
> Thanks,
>
> Christoph
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100917/f8e197b8/attachment.htm>
More information about the kde-core-devel
mailing list