Review Request: New KIO::UDSEntry::UDS_COMMENT

[Sebastian Trueg]

> On 2010-09-14 19:14:34, Ingo Klöcker wrote:
> > Did you consider localization? Will a localized string be put into KIO::UDSEntry::UDS_COMMENT? Does KIO always use the same language as the calling application?

I did not consider it. But the same applies to UDS_DISPLAY_TYPE which already exists. Also I doubt we have situations in which the KIO slave runs with a different language as the client. After all clients and kio slaves use the same kdeinit session which has only one configuration, ie. only one language. At least that is how I understand the matter. Maybe dfaure can shed some light.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5307/#review7608
-----------------------------------------------------------


On 2010-09-14 18:29:23, Sebastian Trueg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5307/
> -----------------------------------------------------------
> 
> (Updated 2010-09-14 18:29:23)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Summary
> -------
> 
> Yes, what can I say - I like UDS entries. :)
> This time I just want a generic comment entry which allows to attach any information to the file item including rich text formatting. I want to use it to provide context information in search results.
> See also my blog: https://trueg.wordpress.com/2010/09/10/someone-requested-excerpts-for-query-results/
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kio/kio/kfileitem.h 1172303 
>   trunk/KDE/kdelibs/kio/kio/kfileitem.cpp 1172303 
>   trunk/KDE/kdelibs/kio/kio/kfileitemdelegate.h 1171417 
>   trunk/KDE/kdelibs/kio/kio/kfileitemdelegate.cpp 1171417 
>   trunk/KDE/kdelibs/kio/kio/udsentry.h 1171417 
> 
> Diff: http://svn.reviewboard.kde.org/r/5307/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sebastian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100915/c65ce199/attachment.htm>