Implementing shift delete in dolphin, some help would be nice.

Ingo Klöcker kloecker at kde.org
Tue Sep 14 19:53:11 BST 2010


On Tuesday 14 September 2010, Mark wrote:
> On Mon, Sep 13, 2010 at 11:13 PM, Lubos Lunak <l.lunak at suse.cz> wrote:
> > On Monday 13 of September 2010, Mark wrote:
> > > On Mon, Sep 13, 2010 at 10:00 PM, Mark <markg85 at gmail.com> wrote:
> > > > --- src/dolphincontextmenu.cpp (revision 1174907)
> > > > +++ src/dolphincontextmenu.cpp (working copy)
> > > > @@ -69,6 +69,9 @@
> > > > 
> > > >      const DolphinView* view =
> > > > 
> > > > m_mainWindow->activeViewContainer()->view(); m_selectedUrls =
> > > > view->selectedUrls();
> > > > 
> > > >      m_selectedItems = view->selectedItems();
> > > > 
> > > > +    m_keyInfo = new KModifierKeyInfo();
> >  
> >  And who deletes it?
> 
> Not in the above patch, but the destructor now does that:
> DolphinContextMenu::~DolphinContextMenu()

Please use QScopedPointer<KModifierKeyInfo> for m_keyInfo instead of a 
raw pointer that you have to delete manually.


Regards,
Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100914/a83ac39e/attachment.sig>


More information about the kde-core-devel mailing list