[PATCH] Cache returned KIconLoader pixmaps in 4.5.2
Torgny Nyblom
kde at nyblom.org
Tue Sep 14 05:46:44 BST 2010
On Mon, 13 Sep 2010 20:37:11 +0200
Ingo Klöcker <kloecker at kde.org> wrote:
[...]
> Maybe not, but something like
> QString("%1_%2_%3").arg(name).arg(size).arg(overlays.join("_"))
> is completely braindead because it's horribly slow.
>
> What about
> return ( group == KIconLoader::User ? QLatin1Literal("$kicou_") :
> QLatin1Literal("$kico_") ) % name
> % QLatin1Char('_')
> % QString::number(size)
> % QLatin1Char('_')
> % overlays.join("_")
> % ( group >= 0 ? mpEffect.fingerprint(group, state) :
> QString("noeffect") ); ?
Better.
/Regards
Torgny
More information about the kde-core-devel
mailing list