Review Request: Allow application language to be reset to default language

Albert Astals Cid aacid at kde.org
Sun Sep 12 22:19:39 BST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5324/#review7565
-----------------------------------------------------------


The code seems quite straighforward, did you do testing?

- Albert


On 2010-09-12 11:07:34, Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5324/
> -----------------------------------------------------------
> 
> (Updated 2010-09-12 11:07:34)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> As mentioned in the bug report, if you change the application language once, you cannot go back to "default" language, i.e. whenever you change the language later, you have to adjust the language in all applications.
> 
> This patch adds a "Defaults" button which resets the application language (list) to empty, i.e. on subsequent starts, the application runs with the default language.
> 
> 
> This addresses bug 230108.
>     https://bugs.kde.org/show_bug.cgi?id=230108
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/dialogs/kswitchlanguagedialog_p.h 1174410 
>   /trunk/KDE/kdelibs/kdeui/dialogs/kswitchlanguagedialog_p.cpp 1174410 
> 
> Diff: http://svn.reviewboard.kde.org/r/5324/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christoph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100912/302eb139/attachment.htm>


More information about the kde-core-devel mailing list