Review Request: Make KNewFileMenu working asynchronously (don't block plasma shell from folderview)

[Björn Ruberg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/4964/
-----------------------------------------------------------

(Updated 2010-09-08 20:26:19.953648)


Review request for kdelibs and David Faure.


Changes
-------

Added a static_cast instead of C-cast and stored m_strategy by value


Summary
-------

This patch makes the dialogs created by KNewFileMenu asynchronously. It's now possible to get non-modal dialogs with it. This is a feature that is needed for plasma folderview, because modal dialogs block the whole plasma shell. So this is the main part of a fix for bug #167243.
By the default the dialogs will stay modal, so there should be no change for other applications. Folderview just needs to call setModal(false) on the KNewFileMenu (have a patch for that, too). But as this touches much code (and orders methods alphabetically ;) ) you can never be sure that there is no change.

Please have closer look whether the dialogs are deleted probably. I'm not doing it directly but relying on Qt::WA_DeleteOnClose. 


This addresses bug #167243.
    https://bugs.kde.org/show_bug.cgi?id=#167243


Diffs (updated)
-----

  /trunk/KDE/kdelibs/kfile/knewfilemenu.h 1166313 
  /trunk/KDE/kdelibs/kfile/knewfilemenu.cpp 1166313 

Diff: http://svn.reviewboard.kde.org/r/4964/diff


Testing
-------

There are five different code pathes that I have worked on:
- create directory
- create normal file
- create symlink
- create URL 
- create .desktop file 

I tested all of them and they work for me.


Thanks,

Björn

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100908/3a3fd8f3/attachment.htm>