Review Request: Fix KUrlNavigator to send raw data (instead of KUrl) to KUrlFilter (also fixes bug: 153347)

Mark markg85 at gmail.com
Tue Sep 7 23:44:41 BST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5284/
-----------------------------------------------------------

(Updated 2010-09-07 22:44:40.762419)


Review request for Dolphin and kdelibs.


Changes
-------

The second patch differes quite a lot from the initial patch thus renamed the title to show the new intention.


Summary (updated)
-------

When a url starts with \\ it can be assumed that the user wants to access a network path. Nothing else starts with \\ anyway.
This patch adds a KUriFilter that converts a windows network path "\\home\path\to\folder" to a samba path "smb://home/path/to/folder".
The filter is added in KUrlNavigator thus all apps that make use of that will be affected.

OK to commit? (since i'm allowed to commit now ^_^)


This addresses bug 153347.
    https://bugs.kde.org/show_bug.cgi?id=153347


Diffs
-----

  trunk/KDE/kdelibs/kfile/kurlnavigator.cpp 1172686 

Diff: http://svn.reviewboard.kde.org/r/5284/diff


Testing
-------

I tested it on some network shares to access it by the windows path names and it seems to work just fine. No issues so far.


Thanks,

Mark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100907/f3961274/attachment.htm>


More information about the kde-core-devel mailing list