Review Request: Translate windows network path names to samba (bug: 153347)

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5284/#review7464
-----------------------------------------------------------


kshorturifilter already deals with UNC ; so I fail to see why this is needed. See line #227 onwards under kdebase/runtime/kurifilter-plugins/shorturi/kshorturifilter.cpp

- Dawit


On 2010-09-07 20:42:22, Mark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5284/
> -----------------------------------------------------------
> 
> (Updated 2010-09-07 20:42:22)
> 
> 
> Review request for Dolphin and kdelibs.
> 
> 
> Summary
> -------
> 
> When a url starts with \\ it can be assumed that the user wants to access a network path. Nothing else starts with \\ anyway.
> This patch adds a KUriFilter that converts a windows network path "\\home\path\to\folder" to a samba path "smb://home/path/to/folder".
> The filter is added in KUrlNavigator thus all apps that make use of that will be affected.
> 
> OK to commit? (since i'm allowed to commit now ^_^)
> 
> 
> This addresses bug 153347.
>     https://bugs.kde.org/show_bug.cgi?id=153347
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/runtime/kurifilter-plugins/CMakeLists.txt 1172686 
>   trunk/KDE/kdebase/runtime/kurifilter-plugins/backwardslashnetworkpath/CMakeLists.txt PRE-CREATION 
>   trunk/KDE/kdebase/runtime/kurifilter-plugins/backwardslashnetworkpath/bsnpfilter.cpp PRE-CREATION 
>   trunk/KDE/kdebase/runtime/kurifilter-plugins/backwardslashnetworkpath/bsnpfilter.desktop PRE-CREATION 
>   trunk/KDE/kdebase/runtime/kurifilter-plugins/backwardslashnetworkpath/bsnpfilter.h PRE-CREATION 
>   trunk/KDE/kdelibs/kfile/kurlnavigator.cpp 1172686 
> 
> Diff: http://svn.reviewboard.kde.org/r/5284/diff
> 
> 
> Testing
> -------
> 
> I tested it on some network shares to access it by the windows path names and it seems to work just fine. No issues so far.
> 
> 
> Thanks,
> 
> Mark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100907/4115d61f/attachment.htm>