Review Request: Fix KUrlNavigator to send raw data (instead of KUrl) to KUriFilter (also fixes bug: 153347)

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5284/#review7471
-----------------------------------------------------------

Ship it!


One final change and after that I have no objections to you commiting it...


trunk/KDE/kdelibs/kfile/kurlnavigator.cpp
<http://svn.reviewboard.kde.org/r/5284/#comment7676>

    I think you should also handle the case where the filtering fails by simply fallback to what the previous code did, i.e.
    
    if (KUriFilter::self()->filterUri(filteredData, QStringList() << "kshorturifilter" << "kurisearchfilter"))
        return filteredData.uri();
    else
        return KUrl(filteredData.typedString());
    



trunk/KDE/kdelibs/kfile/kurlnavigator.cpp
<http://svn.reviewboard.kde.org/r/5284/#comment7677>

    you don't need the .url() here since the function returns a KUrl as shown in the sample code above.


- Dawit


On 2010-09-08 01:57:41, Mark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5284/
> -----------------------------------------------------------
> 
> (Updated 2010-09-08 01:57:41)
> 
> 
> Review request for Dolphin and kdelibs.
> 
> 
> Summary
> -------
> 
> When a url starts with \\ it can be assumed that the user wants to access a network path. Nothing else starts with \\ anyway.
> 
> This patch fixes KUrlNavigator to send the right data to KUriFilter which also fixes at the very least bug 153347.
> 
> OK to commit? (since i'm allowed to commit now ^_^)
> 
> 
> This addresses bug 153347.
>     https://bugs.kde.org/show_bug.cgi?id=153347
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kfile/kurlnavigator.cpp 1172686 
> 
> Diff: http://svn.reviewboard.kde.org/r/5284/diff
> 
> 
> Testing
> -------
> 
> I tested it on some network shares to access it by the windows path names and it seems to work just fine. No issues so far.
> 
> 
> Thanks,
> 
> Mark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100908/bc5ee335/attachment.htm>