Review Request: open remote urls using kioexec if the app doesn't support the protocol

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5280/#review7458
-----------------------------------------------------------

Ship it!


Thanks. Some time ago I had started a similar patch for neoclust but never got around finishing it to the point where it works in all cases ;-)
Yours looks good.

- David


On 2010-09-07 17:46:24, Lubos Lunak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5280/
> -----------------------------------------------------------
> 
> (Updated 2010-09-07 17:46:24)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Summary
> -------
> 
> Opening remote URLs does not work well with non-KDE applications that claim to support remote URLs (%u/%U in Exec in .desktop) but do not support the particular protocol. For example opening a smb:// share in Dolphin and trying to open a document using OpenOffice.org launches OOo with the smb:// URL, which fails (silently, because OOo couldn't be bothered with an error message apparently).
> 
> This patch makes KIO fall back to using kioexec also for these cases.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kio/kio/krun.cpp 1154979 
> 
> Diff: http://svn.reviewboard.kde.org/r/5280/diff
> 
> 
> Testing
> -------
> 
> Tested the above case -> kioexec, and also with a KDE app -> opened directly.
> 
> 
> Thanks,
> 
> Lubos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100907/2f14862b/attachment.htm>