Review Request: Fix KArchiveFile::copyTo() for large files

[Christoph Feck]

> On 2010-09-07 02:18:11, Lamarque Souza wrote:
> > /trunk/KDE/kdelibs/kdecore/io/karchive.cpp, line 667
> > <http://svn.reviewboard.kde.org/r/4938/diff/2/?file=33554#file33554line667>
> >
> >     Somehow this patch makes superkaramba crash when the maindata.xml file has a python_module tag. When reverting this patch superkaramba does not crash anymore.
> >     I think the file position pointer is being corrupted somehow because there is always a short read on the .py file and all text files are corrupted,
> >     even the ones that do not suffered short read.

Should be fixed in trunk and 4.5 branch. If you can still reproduce after r1171342, please add a comment.


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/4938/#review7444
-----------------------------------------------------------


On 2010-08-10 23:29:41, Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/4938/
> -----------------------------------------------------------
> 
> (Updated 2010-08-10 23:29:41)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This fixes KArchiveFile::copyTo() to read in chunks (same as KArchive::addLocalFile(), i.e. 8192 byte chunks) instead of loading the whole file into a single QByteArray (and overflow large files due to that).
> 
> 
> This addresses bug 237124.
>     https://bugs.kde.org/show_bug.cgi?id=237124
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdecore/io/karchive.cpp 1161850 
> 
> Diff: http://svn.reviewboard.kde.org/r/4938/diff
> 
> 
> Testing
> -------
> 
> I successfully downloaded and installed the UNSO NOMAD catalog mentioned in the bug report using the KStars GHNS dialog. During download and copying/extracting the RES memory size of process kstars did not exceed 60 MB. The download file size was 1450631611 (1.35 GiB), the extracted destination file size was 2173117930 (2.02 GiB).
> 
> 
> Thanks,
> 
> Christoph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100907/00197e01/attachment.htm>