Review Request: Use KFileItem::targetUrl() instead of KFileItem::url() in PreviewJob

Sebastian Trueg trueg at
Mon Sep 6 21:36:22 BST 2010

This is an automatically generated e-mail. To reply, visit:

(Updated 2010-09-06 20:36:22.049722)

Review request for kdelibs.


Use mostLocalUrl() instead of targetUrl(). I also added a simplyfied version of KFileItem::mostLocalUrl() since we forgot to "fix" the old version's parameter in 4.0.


Currently the PreviewJob uses KFileItem::url() to generate the preview for files. However, today targetUrl() is the correct one to use since other hierarchies than the file:/ one can contain local files.
To be precise one would even have to check for UDS_LOCAL_FILE but using targetUrl() is a good start.
Since PreviewJob is a rather big class I would like to have someone look at the patch to check if I missed any url() -> targetUrl() replacement.

This addresses bug 248234.

Diffs (updated)

  trunk/KDE/kdelibs/kio/kio/kfileitem.h 1171417 
  trunk/KDE/kdelibs/kio/kio/kfileitem.cpp 1171417 
  trunk/KDE/kdelibs/kio/kio/previewjob.cpp 1171417 





-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list