Review Request: Add custom button labels for yes, no, continue and cancel buttons in kdialog

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5727/#review8427
-----------------------------------------------------------

Ship it!


Looks good, I like TODOs being implemented :-)

Just one minor issue:


/trunk/KDE/kdebase/apps/kdialog/kdialog.cpp
<http://svn.reviewboard.kde.org/r/5727/#comment8752>

    Is i18n("yes") a good tooltip? Surely if the caller of kdialog passes "--yes-label Maybe", then the tooltip for the "Maybe" button saying "Yes" would be confusing.
    
    In other words the fact that this is a button which leads to a return code of KDialog::Yes is an internal detail which should not appear to the user in a tooltip, IMHO.


- David


On 2010-10-29 16:32:13, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5727/
> -----------------------------------------------------------
> 
> (Updated 2010-10-29 16:32:13)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Using the newly added capability to get parameters that start with no, added four parameters, in the most common way used in cdialog and xdialog.
> --yes-label
> --no-label
> --cancel-label
> --continue-label
> 
> 
> This addresses bug 129498.
>     https://bugs.kde.org/show_bug.cgi?id=129498
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/apps/kdialog/kdialog.cpp 1188521 
> 
> Diff: http://svn.reviewboard.kde.org/r/5727/diff
> 
> 
> Testing
> -------
> 
> kdialog --yes-label "&Siiiii" --no-label "&Noooooo" --cancel-label "&Cancelaaar" --yesnocancel Hola
> kdialog --continue-label "&Continuuuue" --cancel-label "&Cancelaaar" --warningcontinuecancel Hola
> 
> 
> Thanks,
> 
> Jaime
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101029/24ee6967/attachment.htm>