Review Request: in Kcmdlineargs, no<whatever> wiith a param is now a normal option (v2)

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5637/#review8397
-----------------------------------------------------------

Ship it!


Makes sense. I grepped around a bit (kdebase, kdepim) to see if anyone was already using --nofoo with a param, but it didn't really make sense before, so nobody was doing it indeed ;)

- David


On 2010-10-25 19:55:41, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5637/
> -----------------------------------------------------------
> 
> (Updated 2010-10-25 19:55:41)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> I need an option called no-label followed by some text.
> With this patch, no is not an special prefix if the option needs a parameter.
> 
> Also changed the documentation in the header.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdecore/kernel/kcmdlineargs.h 1188854 
>   /trunk/KDE/kdelibs/kdecore/kernel/kcmdlineargs.cpp 1188854 
> 
> Diff: http://svn.reviewboard.kde.org/r/5637/diff
> 
> 
> Testing
> -------
> 
> run make test in kdelibs build root, previous results here:
> 
>           1 - nepomuk-queryparsertest (Failed)
>           2 - nepomuk-querytest (Failed)
>           4 - nepomuk-resourcetest (Failed)
>          11 - kdecore-kstandarddirstest (Failed)
>          40 - kdecore-kglobaltest (Timeout)
>          43 - kdecore-kconfigafterkglobaltest1 (Failed)
>          44 - kdecore-kconfigafterkglobaltest2 (Failed)
>          45 - kdecore-ktcpsockettest (Failed)
>          94 - kptyprocesstest (Failed)
>          96 - kio-krununittest (Failed)
>         137 - kate-completion_test (Failed)
>         138 - kate-searchbar_test (Failed)
>         140 - kate-movingrange_test (Failed)
>         144 - kate-indenttest (Failed)
> 
> no more regressions added by this patch.
> 
> 
> Thanks,
> 
> Jaime
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101027/68e26f15/attachment.htm>