Review Request: Additions to KParts::HTMLExtension and KParts::SelectorInterface...

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5696/#review8383
-----------------------------------------------------------

Ship it!


Looks good, thanks for this. Just some minor things below.


trunk/KDE/kdelibs/kparts/htmlextension.h
<http://svn.reviewboard.kde.org/r/5696/#comment8702>

    No semicolon needed



trunk/KDE/kdelibs/kparts/htmlextension.h
<http://svn.reviewboard.kde.org/r/5696/#comment8701>

    Your editor adds trailing whitespace? Mine removes it, so this can go back and forth quite a bit ;)



trunk/KDE/kdelibs/kparts/htmlextension.cpp
<http://svn.reviewboard.kde.org/r/5696/#comment8700>

    why kurl.h?


- David


On 2010-10-27 08:21:42, Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5696/
> -----------------------------------------------------------
> 
> (Updated 2010-10-27 08:21:42)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Summary
> -------
> 
> Purpose of this patch to add the ability to query only selected content to KParts::SelectorInterface class.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/khtml/khtml_ext.h 1190154 
>   trunk/KDE/kdelibs/khtml/khtml_ext.cpp 1190154 
>   trunk/KDE/kdelibs/kparts/htmlextension.h 1190154 
>   trunk/KDE/kdelibs/kparts/htmlextension.cpp 1190154 
> 
> Diff: http://svn.reviewboard.kde.org/r/5696/diff
> 
> 
> Testing
> -------
> 
> Tested both khtml and kwebkitpart using kget's konqueror extension for functionality...
> 
> 
> Thanks,
> 
> Dawit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101027/56f17480/attachment.htm>