Review Request: Using KWallet to store Cookies

[José Millán Soto]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/4927/
-----------------------------------------------------------

(Updated 2010-10-26 01:24:01.779944)


Review request for kdelibs.


Changes
-------

New version of the patch, it corrects the typo appointed by Michael Leupold and calls cookie.name() only once for each cookie.


Summary
-------

Currently cookies are stored in a plain text file. This patch allows KCookieJar to store the cookies securely using KWallet.

The main problem I had writing this patch was that when a web page is requested, KIO ask for the cookies to kded using dbus. In the first implementations that I wrote, if the user took too long to open the wallet, KIO received a dbus timeout.

To prevent this, if it takes more than 10 seconds to open the wallet, the web page will be requested without sending the cookies (or sending the available cookies if there's still the plain text cookie file). If the wallet is opened after that, the cookies stored in the wallet will be available since then.

Because of this, the feature is disabled by default.


Diffs (updated)
-----

  /trunk/KDE/kdebase/apps/konqueror/settings/kio/kcookiespolicies.cpp 1189829 
  /trunk/KDE/kdebase/apps/konqueror/settings/kio/kcookiespoliciesdlg.ui 1189829 
  /trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookiejar.h 1189787 
  /trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookiejar.cpp 1189787 
  /trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookieserver.h 1189787 
  /trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookieserver.cpp 1189787 

Diff: http://svn.reviewboard.kde.org/r/4927/diff


Testing
-------


Thanks,

José

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101026/264d8270/attachment.htm>