Review Request: Add support for parsing relative present actions in notification contexts

[Olivier Goffart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5631/#review8339
-----------------------------------------------------------



trunk/KDE/kdebase/runtime/knotify/knotify.cpp
<http://svn.reviewboard.kde.org/r/5631/#comment8617>

    I do not really like this JavaStyle iterator.    I think foreach would be better and more intuitive in that case.



trunk/KDE/kdebase/runtime/knotify/knotify.cpp
<http://svn.reviewboard.kde.org/r/5631/#comment8616>

    This is leaking.  Allocating the Event on the stack should work.



trunk/KDE/kdebase/runtime/knotify/knotify.cpp
<http://svn.reviewboard.kde.org/r/5631/#comment8619>

    Probably a QSet<QString> is the right structure here.  Does not matter much.



trunk/KDE/kdebase/runtime/knotify/knotify.cpp
<http://svn.reviewboard.kde.org/r/5631/#comment8618>

    What about string.mid(1)?


- Olivier


On 2010-10-15 11:08:19, Jacopo De Simoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5631/
> -----------------------------------------------------------
> 
> (Updated 2010-10-15 11:08:19)
> 
> 
> Review request for kdelibs and Olivier Goffart.
> 
> 
> Summary
> -------
> 
> This patch allows to specify, for some specific notification contexts, present actions that should be either added or removed with 
> respect to the default (i.e. without context) ones. E.g. one could write notifyrc files containing:
> 
> [Event/someevent/presentation/fullscreen]
> Action=-Sound|-Popup
> 
> [Event/someevent/quietbutverbose/whatever]
> Action=+Popup|-Sound
> 
> [Event/someevent/morespecificnotifier/present]
> Action=-Popup
> 
> This lets the user to customize non-contextualized actions via the usual interface, but at the same time allows some control by the
> developer in some particular situations.
> 
> The patch changes knotifyconfig.cpp in order to parse contextualized actions also in the system-wide file and includes some basic 
> validity check in such a way to recognize invalid expressions such as:
> 
> Action=-Popup|Sound
> 
> I don't know where to document this behaviour; any help on that is most appreciated.
> Thanks!
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/runtime/knotify/knotify.cpp 1185812 
>   trunk/KDE/kdebase/runtime/knotify/knotifyconfig.cpp 1185812 
> 
> Diff: http://svn.reviewboard.kde.org/r/5631/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jacopo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101025/04b3944f/attachment.htm>