Review Request: A Facet and search GUI API for Nepomuk

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5671/
-----------------------------------------------------------

(Updated 2010-10-25 10:16:32.003113)


Review request for kdelibs and Vishesh Handa.


Changes
-------

Updating again - can't seem to stop. :P
This time I added a feature to SimpleFacet which allows to set a condition. The documentation says more.
Apart from that I changed the virtual method Facet::setClientQuery() to a non-virtual one with a virtual helper method Facet::handleClientQueryChange(). Comments? Is this good API?

I also would like to get feedback on FacetWidget which is basically a wrapper around the rest. For now I duplicated most of the FacetModel API in it. The other possibility would be to expose the model through one method. Which one is better?


Summary
-------

I have been struggling with creating a good facet API for a long time now. I finally reached a point where I am happy with the result. IMHO this is essential enough to get into kdelibs/nepomuk. The first usage will obviously be Dolphin, closely followed by the file dialog. All in all this will make it so much simpler to provide Nepomuk powered search capabilities in applications.
Anyway, this review request is intended for an API review before I commit.


Diffs (updated)
-----

  trunk/KDE/kdelibs/includes/CMakeLists.txt 1187872 
  trunk/KDE/kdelibs/includes/Nepomuk/Utils/DynamicResourceFacet PRE-CREATION 
  trunk/KDE/kdelibs/includes/Nepomuk/Utils/Facet PRE-CREATION 
  trunk/KDE/kdelibs/includes/Nepomuk/Utils/FacetWidget PRE-CREATION 
  trunk/KDE/kdelibs/includes/Nepomuk/Utils/ResourceModel PRE-CREATION 
  trunk/KDE/kdelibs/includes/Nepomuk/Utils/SearchWidget PRE-CREATION 
  trunk/KDE/kdelibs/includes/Nepomuk/Utils/SimpleFacet PRE-CREATION 
  trunk/KDE/kdelibs/includes/Nepomuk/Utils/SimpleResourceModel PRE-CREATION 
  trunk/KDE/kdelibs/nepomuk/Mainpage.dox 1187872 
  trunk/KDE/kdelibs/nepomuk/utils/CMakeLists.txt 1187872 
  trunk/KDE/kdelibs/nepomuk/utils/datefacet.h PRE-CREATION 
  trunk/KDE/kdelibs/nepomuk/utils/datefacet.cpp PRE-CREATION 
  trunk/KDE/kdelibs/nepomuk/utils/daterange.h PRE-CREATION 
  trunk/KDE/kdelibs/nepomuk/utils/daterange.cpp PRE-CREATION 
  trunk/KDE/kdelibs/nepomuk/utils/daterangeselectionwidget.h PRE-CREATION 
  trunk/KDE/kdelibs/nepomuk/utils/daterangeselectionwidget.cpp PRE-CREATION 
  trunk/KDE/kdelibs/nepomuk/utils/daterangeselectionwidget.ui PRE-CREATION 
  trunk/KDE/kdelibs/nepomuk/utils/dynamicresourcefacet.h PRE-CREATION 
  trunk/KDE/kdelibs/nepomuk/utils/dynamicresourcefacet.cpp PRE-CREATION 
  trunk/KDE/kdelibs/nepomuk/utils/facet.h PRE-CREATION 
  trunk/KDE/kdelibs/nepomuk/utils/facet.cpp PRE-CREATION 
  trunk/KDE/kdelibs/nepomuk/utils/facetdelegate.h PRE-CREATION 
  trunk/KDE/kdelibs/nepomuk/utils/facetdelegate.cpp PRE-CREATION 
  trunk/KDE/kdelibs/nepomuk/utils/facetfiltermodel.h PRE-CREATION 
  trunk/KDE/kdelibs/nepomuk/utils/facetfiltermodel.cpp PRE-CREATION 
  trunk/KDE/kdelibs/nepomuk/utils/facetmodel.h PRE-CREATION 
  trunk/KDE/kdelibs/nepomuk/utils/facetmodel.cpp PRE-CREATION 
  trunk/KDE/kdelibs/nepomuk/utils/facetwidget.h PRE-CREATION 
  trunk/KDE/kdelibs/nepomuk/utils/facetwidget.cpp PRE-CREATION 
  trunk/KDE/kdelibs/nepomuk/utils/resourcemodel.h PRE-CREATION 
  trunk/KDE/kdelibs/nepomuk/utils/resourcemodel.cpp PRE-CREATION 
  trunk/KDE/kdelibs/nepomuk/utils/searchlineedit.h PRE-CREATION 
  trunk/KDE/kdelibs/nepomuk/utils/searchlineedit.cpp PRE-CREATION 
  trunk/KDE/kdelibs/nepomuk/utils/searchwidget.h PRE-CREATION 
  trunk/KDE/kdelibs/nepomuk/utils/searchwidget.cpp PRE-CREATION 
  trunk/KDE/kdelibs/nepomuk/utils/searchwidget_p.h PRE-CREATION 
  trunk/KDE/kdelibs/nepomuk/utils/simplefacet.h PRE-CREATION 
  trunk/KDE/kdelibs/nepomuk/utils/simplefacet.cpp PRE-CREATION 
  trunk/KDE/kdelibs/nepomuk/utils/simpleresourcemodel.h PRE-CREATION 
  trunk/KDE/kdelibs/nepomuk/utils/simpleresourcemodel.cpp PRE-CREATION 

Diff: http://svn.reviewboard.kde.org/r/5671/diff


Testing
-------


Thanks,

Sebastian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101025/db9b0d04/attachment.htm>