Review Request: Use a KDualAction to show/hide toolbar if there is only one

[Thomas Friedrichsmeier]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5641/#review8310
-----------------------------------------------------------


As far as I can see, the ToolbarVisibilitySpy is never deleted. I suggest connecting deleteLater() to the action's destroyed()-signal.

- Thomas


On 2010-10-17 10:30:53, Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5641/
> -----------------------------------------------------------
> 
> (Updated 2010-10-17 10:30:53)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Now that the actions to show/hide menubar and statusbar are KDualAction, the action which show/hide the toolbar should be changed as well for consistency.
> 
> I only changed the case where there is only one toolbar because when there are multiple toolbars the action is turned into a submenu labeled "Toolbars Shown". It makes sense here to have toggle actions because the submenu only lists the name of the toolbars, without verbs.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kdeui/xmlgui/ktoolbarhandler.cpp 1186567 
> 
> Diff: http://svn.reviewboard.kde.org/r/5641/diff
> 
> 
> Testing
> -------
> 
> Tested with a single-toolbar application (KWrite) and a multi-toolbar one (Konqueror).
> 
> 
> Thanks,
> 
> Aurélien
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101022/d7c43e59/attachment.htm>