Review Request: in Kcmdlineargs, no<whatever> wiith a param is now a normal option (v2)

[Jaime Torres]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5637/
-----------------------------------------------------------

(Updated 2010-10-19 20:42:47.148763)


Review request for kdelibs.


Changes
-------

I realized that there are two kind of no options: flags, like --norender or options with parameters, like --no-label "&No".
Therefore, only check if the no option has parameters, and voila.
Tested again, no regressions.
I have also documented that alias are one char only. Yes, I got confused :-(


Summary (updated)
-------

I need an option called no-label followed by some text.
With this patch, no is not an special prefix if the option needs a parameter.

Also changed the documentation in the header.


Diffs (updated)
-----

  /trunk/KDE/kdelibs/kdecore/kernel/kcmdlineargs.h 1186814 
  /trunk/KDE/kdelibs/kdecore/kernel/kcmdlineargs.cpp 1186814 

Diff: http://svn.reviewboard.kde.org/r/5637/diff


Testing (updated)
-------

run make test in kdelibs build root, previous results here:

          1 - nepomuk-queryparsertest (Failed)
          2 - nepomuk-querytest (Failed)
          4 - nepomuk-resourcetest (Failed)
         11 - kdecore-kstandarddirstest (Failed)
         40 - kdecore-kglobaltest (Timeout)
         43 - kdecore-kconfigafterkglobaltest1 (Failed)
         44 - kdecore-kconfigafterkglobaltest2 (Failed)
         45 - kdecore-ktcpsockettest (Failed)
         94 - kptyprocesstest (Failed)
         96 - kio-krununittest (Failed)
        137 - kate-completion_test (Failed)
        138 - kate-searchbar_test (Failed)
        140 - kate-movingrange_test (Failed)
        144 - kate-indenttest (Failed)

no more regressions added by this patch.


Thanks,

Jaime

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101019/9b56f9c6/attachment.htm>