Review Request: prefix dependent IMPORTS_INSTALL_DIR

[Alexander Neundorf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5640/#review8197
-----------------------------------------------------------


Looks good, but I didn't actually try it.
I guess you verified that KDE4_IMPORTS_INSTALL_DIR ends up properly in the KDELibsDependencies.cmake file and can be used later on ?
If so, go ahead and commit :-)

Alex


- Alexander


On 2010-10-17 10:02:11, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5640/
> -----------------------------------------------------------
> 
> (Updated 2010-10-17 10:02:11)
> 
> 
> Review request for kdelibs, KDE PIM, Pino Toscano, and Alexander Neundorf.
> 
> 
> Summary
> -------
> 
> since everything installed by KDE should be under its prefix, is not possible to install stuff in the system global Qt imports directory.
> define a new variable for the installation to make sure all projects using QML (at the moment Plasma and Kdepim)will install their imports under the same prefix
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/CreateKDELibsDependenciesFile.cmake 1185165 
>   /trunk/KDE/kdelibs/cmake/modules/FindKDE4Internal.cmake 1185165 
> 
> Diff: http://svn.reviewboard.kde.org/r/5640/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101017/c378d8ae/attachment.htm>