Review Request: prefix dependent IMPORTS_INSTALL_DIR

[Marco Martin]

> On 2010-10-16 21:07:44, Volker Krause wrote:
> > Thanks for taking care of this, we definitely need such a CMake variable.
> > 
> > In kdepim we currently install QML components to ${PLUGIN_INSTALL_DIR}/imports instead of ${PREFIX}/imports though. Since QML components can not only be (platform independent) QML files but also compiled C++ plugins, something under ${PREFIX}/lib seemed more appropriate.

yeah, that's where i moved them initially as well, then talking with other people (ehi, Pino :p) it was raised the point that since they are not "normal" kde plugins, should reflect where they are installed globally in Qt (just imports).
now, to me ${PLUGIN_INSTALL_DIR}/imports is fine as well, even given it's so easy adding that folder to the declarative engine


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5640/#review8188
-----------------------------------------------------------


On 2010-10-17 10:02:11, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5640/
> -----------------------------------------------------------
> 
> (Updated 2010-10-17 10:02:11)
> 
> 
> Review request for kdelibs, KDE PIM, Pino Toscano, and Alexander Neundorf.
> 
> 
> Summary
> -------
> 
> since everything installed by KDE should be under its prefix, is not possible to install stuff in the system global Qt imports directory.
> define a new variable for the installation to make sure all projects using QML (at the moment Plasma and Kdepim)will install their imports under the same prefix
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/CreateKDELibsDependenciesFile.cmake 1185165 
>   /trunk/KDE/kdelibs/cmake/modules/FindKDE4Internal.cmake 1185165 
> 
> Diff: http://svn.reviewboard.kde.org/r/5640/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101017/0cf219b6/attachment.htm>