Review Request: Menubar and statusbar visibility actions: replace togglable "show" actions with "show/hide" actions

[Aurélien Gâteau]

> On 2010-10-15 21:03:58, David Faure wrote:
> > Hey don't let a short discussion discourage you.
> > 
> > If I understand correctly, this patch restores the KDE3 behavior: Show foo, Hide foo, no checkbox. This is what we wanted at the time; everything that happened since was unwanted side effects from Qt4. So I see no reason why we shouldn't apply this and get the behavior that we had actually decided for, at the time.
> 
> Parker Coates wrote:
>     So where is it appropriate to use KToggleAction? Almost every KTA can be converted to a KDA by prepending two opposite verbs to the to it. (Ex: Show/Hide, Start/Stop, Lock/Unlock, Enable/Disable, Activate/Deactivate)
>     
>     Does this change essentially deprecate KToggleAction?
> 
> Aurélien Gâteau wrote:
>     @David: thanks, I am going to reopen the request then.
>     
>     @Parker: you may want to read this: http://techbase.kde.org/Projects/Usability/HIG/Toggle_Buttons . It shows valid uses of KToggleAction (for example: font formatting for a text processor). You will notice it lists "[x] Show" as a valid alternative to "Show/hide". I didn't want to recommend against those "[x] Show" actions when I first wrote this document because I was not sure it would be realist to fix them (KDualAction did not exist back then).
>     
>     When Celeste reviewed the document she suggested to add some recommendations for developers who don't know which solution is best for their situation. I wanted to get through some applications fixes before revisiting this document with some practical recommendation. If this patch goes in I'll add the first recommendation: use "Show/hide" for UI elements.
>

I just committed the changes. Expect new merge requests tomorrow.


- Aurélien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5622/#review8170
-----------------------------------------------------------


On 2010-10-15 22:00:53, Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5622/
> -----------------------------------------------------------
> 
> (Updated 2010-10-15 22:00:53)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> The standard actions to toggle the visibility of the menubar and the statusbar are togglable "show" actions: their label is always "show {menu,status}bar" and they have a checkbox next to them. This means when the user wants to hide the statusbar, he must click an item which says "[x] Show Statusbar". I believe this is less intuitive than if the item label were "Hide Statusbar".
> 
> Attached patch implements this by introducing KStandardAction::showHideMenubar(), KStandardAction::showHideStatusbar() and using showHideStatusbar() in KXmlGuiWindow. It also deprecates KStandardAction::showMenubar() and KStandardAction::hideMenubar().
> (I already have a patch for Konqueror to make use of KStandardAction::showHideMenubar() and will probably patch other applications if this request is approved)
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kdeui/actions/kstandardaction.h 1185607 
>   trunk/KDE/kdelibs/kdeui/actions/kstandardaction.cpp 1185607 
>   trunk/KDE/kdelibs/kdeui/xmlgui/kxmlguiwindow.cpp 1185607 
> 
> Diff: http://svn.reviewboard.kde.org/r/5622/diff
> 
> 
> Testing
> -------
> 
> Tested with Konqueror, KWrite and other KDE applications (more patches to come to provide consistency among applications)
> 
> 
> Thanks,
> 
> Aurélien
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101016/11d86890/attachment.htm>