Review Request: Menubar and statusbar visibility actions: replace togglable "show" actions with "show/hide" actions

[Parker Coates]

> On 2010-10-15 21:03:58, David Faure wrote:
> > Hey don't let a short discussion discourage you.
> > 
> > If I understand correctly, this patch restores the KDE3 behavior: Show foo, Hide foo, no checkbox. This is what we wanted at the time; everything that happened since was unwanted side effects from Qt4. So I see no reason why we shouldn't apply this and get the behavior that we had actually decided for, at the time.

So where is it appropriate to use KToggleAction? Almost every KTA can be converted to a KDA by prepending two opposite verbs to the to it. (Ex: Show/Hide, Start/Stop, Lock/Unlock, Enable/Disable, Activate/Deactivate)

Does this change essentially deprecate KToggleAction?


- Parker


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5622/#review8170
-----------------------------------------------------------


On 2010-10-13 22:19:16, Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5622/
> -----------------------------------------------------------
> 
> (Updated 2010-10-13 22:19:16)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> The standard actions to toggle the visibility of the menubar and the statusbar are togglable "show" actions: their label is always "show {menu,status}bar" and they have a checkbox next to them. This means when the user wants to hide the statusbar, he must click an item which says "[x] Show Statusbar". I believe this is less intuitive than if the item label were "Hide Statusbar".
> 
> Attached patch implements this by introducing KStandardAction::showHideMenubar(), KStandardAction::showHideStatusbar() and using showHideStatusbar() in KXmlGuiWindow. It also deprecates KStandardAction::showMenubar() and KStandardAction::hideMenubar().
> (I already have a patch for Konqueror to make use of KStandardAction::showHideMenubar() and will probably patch other applications if this request is approved)
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kdeui/actions/kstandardaction.h 1185607 
>   trunk/KDE/kdelibs/kdeui/actions/kstandardaction.cpp 1185607 
>   trunk/KDE/kdelibs/kdeui/xmlgui/kxmlguiwindow.cpp 1185607 
> 
> Diff: http://svn.reviewboard.kde.org/r/5622/diff
> 
> 
> Testing
> -------
> 
> Tested with Konqueror, KWrite and other KDE applications (more patches to come to provide consistency among applications)
> 
> 
> Thanks,
> 
> Aurélien
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101015/2640559a/attachment.htm>