Review Request: updated kded4 man page
Arno Rehn
kde at arnorehn.de
Fri Oct 8 19:56:24 BST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5557/#review8045
-----------------------------------------------------------
I do have a bunch of remarks, but anyways: kudos to everyone keeping the docs up-to-date. You rock! :)
/trunk/KDE/kdelibs/doc/kded4/man-kded4.8.docbook
<http://svn.reviewboard.kde.org/r/5557/#comment8275>
At least add the article 'a' to 'series of updates'. Could still be improved I think.
/trunk/KDE/kdelibs/doc/kded4/man-kded4.8.docbook
<http://svn.reviewboard.kde.org/r/5557/#comment8276>
s/new/newly/
and replace the last comma with a semicolon or a full stop.
/trunk/KDE/kdelibs/doc/kded4/man-kded4.8.docbook
<http://svn.reviewboard.kde.org/r/5557/#comment8277>
That sounds as if the check is done by a badly configured dial-up connection.
/trunk/KDE/kdelibs/doc/kded4/man-kded4.8.docbook
<http://svn.reviewboard.kde.org/r/5557/#comment8278>
'a' instead of 'an' would be correct here, I think.
/trunk/KDE/kdelibs/doc/kded4/man-kded4.8.docbook
<http://svn.reviewboard.kde.org/r/5557/#comment8279>
I think this should be 'Provides'. Maybe rephrase, I at least don't quite get what it means.
/trunk/KDE/kdelibs/doc/kded4/man-kded4.8.docbook
<http://svn.reviewboard.kde.org/r/5557/#comment8280>
'kio slave' is probably the correct term here, not 'protocol'. I don't know how technical we want to get here, though.
/trunk/KDE/kdelibs/doc/kded4/man-kded4.8.docbook
<http://svn.reviewboard.kde.org/r/5557/#comment8281>
'Provides various subversion actions for the [...]' is better, I think.
/trunk/KDE/kdelibs/doc/kded4/man-kded4.8.docbook
<http://svn.reviewboard.kde.org/r/5557/#comment8282>
s/provices/provides/
s/notification to/notifications for/
/trunk/KDE/kdelibs/doc/kded4/man-kded4.8.docbook
<http://svn.reviewboard.kde.org/r/5557/#comment8283>
Watches
/trunk/KDE/kdelibs/doc/kded4/man-kded4.8.docbook
<http://svn.reviewboard.kde.org/r/5557/#comment8284>
'Keeps' and 'D-Bus' instead of 'D-BUS'
/trunk/KDE/kdelibs/doc/kded4/man-kded4.8.docbook
<http://svn.reviewboard.kde.org/r/5557/#comment8285>
Same as above
/trunk/KDE/kdelibs/doc/kded4/man-kded4.8.docbook
<http://svn.reviewboard.kde.org/r/5557/#comment8286>
notifications
/trunk/KDE/kdelibs/doc/kded4/man-kded4.8.docbook
<http://svn.reviewboard.kde.org/r/5557/#comment8287>
Clarify, this sounds a bit strange.
/trunk/KDE/kdelibs/doc/kded4/man-kded4.8.docbook
<http://svn.reviewboard.kde.org/r/5557/#comment8288>
notifications
/trunk/KDE/kdelibs/doc/kded4/man-kded4.8.docbook
<http://svn.reviewboard.kde.org/r/5557/#comment8289>
provide
/trunk/KDE/kdelibs/doc/kded4/man-kded4.8.docbook
<http://svn.reviewboard.kde.org/r/5557/#comment8290>
Maybe 'unmounts' instead of 'releases' ?
Again, don't know how technical we want to get in the manpages.
- Arno
On 2010-10-08 18:32:15, Jaime Torres wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5557/
> -----------------------------------------------------------
>
> (Updated 2010-10-08 18:32:15)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> Three questions:
> * Is it wrote in correct English?
> * Is it ok to list the modules in that way and in that page?
> * In the KCM module Service Manager (from where I've copied the names and descriptions) there are 5 descriptions missing (also in the man page):
> * KDED Subversion module
> * KDED module for screen-managment
> * Keyboard Daemon
> * Display Managment change monitor
> * K Remote Control Daemon
> Please, non trivial descriptions?
>
>
> This addresses bug 242582.
> https://bugs.kde.org/show_bug.cgi?id=242582
>
>
> Diffs
> -----
>
> /trunk/KDE/kdelibs/doc/kded4/man-kded4.8.docbook 1183527
>
> Diff: http://svn.reviewboard.kde.org/r/5557/diff
>
>
> Testing
> -------
>
> The man page is more complete, and now can search for out of space
>
>
> Thanks,
>
> Jaime
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101008/f8af74b9/attachment.htm>
More information about the kde-core-devel
mailing list