Review Request: Prevent memory leaks when opening a zip store multiple times

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5536/
-----------------------------------------------------------

(Updated 2010-10-07 19:36:50.465225)


Review request for kdelibs.


Changes
-------

Like this?


Summary
-------

It is possible to accidentally call open() twice. If you do that on a zip store, kgzipfilter will be initialized twice, deflateInit2 will be called twice and we leak memory.


Diffs (updated)
-----

  trunk/KDE/kdelibs/kdecore/compression/kbzip2filter.cpp 1182756 
  trunk/KDE/kdelibs/kdecore/compression/kfilterdev.cpp 1182756 
  trunk/KDE/kdelibs/kdecore/compression/kgzipfilter.cpp 1182756 
  trunk/KDE/kdelibs/kdecore/compression/kxzfilter.cpp 1182756 

Diff: http://svn.reviewboard.kde.org/r/5536/diff


Testing
-------


Thanks,

Boudewijn

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101007/72f7a401/attachment.htm>