Review Request: add QT_IMPORTS_DIR to cmake

[Alexander Neundorf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5541/#review8026
-----------------------------------------------------------


Looks ok.
Maybe the variable could be named QT_QML_IMPORTS_DIR or something like this, to make it more descriptive ?
Please post this also to the cmake bugtracker (http://public.kitware.com/Bug), I would prefer if Clinton, the upstream FindQt4.cmake maintainer would also review it.

Alex


- Alexander


On 2010-10-07 12:50:48, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5541/
> -----------------------------------------------------------
> 
> (Updated 2010-10-07 12:50:48)
> 
> 
> Review request for kdelibs and Alexander Neundorf.
> 
> 
> Summary
> -------
> 
> this defines a new cmake variable, QT_IMPORTS_DIR
> it's used by QML for extra plugins and is usually /usr/imports
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/cmake/modules/FindQt4.cmake 1179394 
> 
> Diff: http://svn.reviewboard.kde.org/r/5541/diff
> 
> 
> Testing
> -------
> 
> used the new variable to install new plugins
> 
> 
> Thanks,
> 
> Marco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101007/4453378e/attachment.htm>