Review Request: Prevent memory leaks when opening a zip store multiple times
Raphael Kubo da Costa
kubito at gmail.com
Wed Oct 6 15:06:37 BST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5536/#review7998
-----------------------------------------------------------
Doesn't the idea apply to KBzip2Filter and KXzFilter as well?
- Raphael
On 2010-10-06 13:36:53, Boudewijn Rempt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5536/
> -----------------------------------------------------------
>
> (Updated 2010-10-06 13:36:53)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> It is possible to accidentally call open() twice. If you do that on a zip store, kgzipfilter will be initialized twice, deflateInit2 will be called twice and we leak memory.
>
>
> Diffs
> -----
>
> trunk/KDE/kdelibs/kdecore/compression/kfilterdev.cpp 1182756
> trunk/KDE/kdelibs/kdecore/compression/kgzipfilter.cpp 1182756
>
> Diff: http://svn.reviewboard.kde.org/r/5536/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Boudewijn
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101006/001e177b/attachment.htm>
More information about the kde-core-devel
mailing list