Review Request: New KIO::UDSEntry::UDS_COMMENT

[Sebastian Trueg]

> On 2010-10-05 21:57:23, David Faure wrote:
> > It's very possible to have kioslaves in a different lang than the app, when using the "switch application language" action, which changes only the app's language, and not the slaves'. But this is something we could fix (quite easily, I think, with slaveConfig stuff, except that slave re-use would be a problem), and it's not related to this request at all, the problem already exists.
> > 
> > What surprises me a little bit in this patch is that the added comment isn't used anywhere; is there a planned dolphin side of this, maybe?

As explained in my blog I will use UDS_COMMENT to report search excerpts. Since that involves changes in kdebase I wanted this review request to pass before proposing the rest.


> On 2010-10-05 21:57:23, David Faure wrote:
> > trunk/KDE/kdelibs/kio/kio/kfileitemdelegate.cpp, line 312
> > <http://svn.reviewboard.kde.org/r/5307/diff/2/?file=35838#file35838line312>
> >
> >     please add a "break;" here, so that the next person who adds a "case:" doesn't forget it.

Will update the diff as soon as the server allows me to. :)


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5307/#review7627
-----------------------------------------------------------


On 2010-09-14 18:29:23, Sebastian Trueg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5307/
> -----------------------------------------------------------
> 
> (Updated 2010-09-14 18:29:23)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Summary
> -------
> 
> Yes, what can I say - I like UDS entries. :)
> This time I just want a generic comment entry which allows to attach any information to the file item including rich text formatting. I want to use it to provide context information in search results.
> See also my blog: https://trueg.wordpress.com/2010/09/10/someone-requested-excerpts-for-query-results/
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kio/kio/kfileitem.h 1172303 
>   trunk/KDE/kdelibs/kio/kio/kfileitem.cpp 1172303 
>   trunk/KDE/kdelibs/kio/kio/kfileitemdelegate.h 1171417 
>   trunk/KDE/kdelibs/kio/kio/kfileitemdelegate.cpp 1171417 
>   trunk/KDE/kdelibs/kio/kio/udsentry.h 1171417 
> 
> Diff: http://svn.reviewboard.kde.org/r/5307/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sebastian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101006/75e58811/attachment.htm>