Review Request: Minor GUI change to rename/overwrite dialog window

Steven Sroka thedude_10160 at
Wed Oct 6 03:43:13 BST 2010

This is an automatically generated e-mail. To reply, visit:

(Updated 2010-10-06 02:43:12.993850)

Review request for kdelibs.


Added warning label when dest modification date > src modification date.

Also formatted source code to confirm to KDE coding style, hence why total number of changed is 95.


This is my first submission to KDE. If I am missing something, don't hesitate to tell me.

This is a slight GUI change to the rename/overwrite dialog window, just to make it more user friendly.

This addresses bug 238942.

Diffs (updated)

  /trunk/KDE/kdelibs/kio/kio/renamedialog.h 1181964 
  /trunk/KDE/kdelibs/kio/kio/renamedialog.cpp 1181964 



Correctly Compiled.
"Eye ball'ed" Code.
Ran code with all possible '_mode' as per
Ran many possible combinations (most if not all) -> move folder to folder, file to file, file to folder, folder to file, and paid attention to creation date.

(I actually found a bug with the preview picture that is shown in a certain scenario - I will create a bug notice for it on soon)


KDE Trunk - Bug
*New - File to File
KDE 4.5 - File to File
Revision 5 Screenshot
New warning



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list