Review Request: Minor GUI change to rename/overwrite dialog window

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5443/#review7984
-----------------------------------------------------------


I liked the idea of telling the user if he's overwriting an older file (usually fine) or a newer file (usually an error). Indeed it made the dialog very wide, so it could be done better. Maybe simply adding a second line "Warning, the destination file is newer!" when this is the case, and not saying anything when it's older or same age?


/trunk/KDE/kdelibs/kio/kio/renamedialog.cpp
<http://svn.reviewboard.kde.org/r/5443/#comment8234>

    Adding spaces in SIGNAL() only makes this slower since Qt will have to remove them.



/trunk/KDE/kdelibs/kio/kio/renamedialog.cpp
<http://svn.reviewboard.kde.org/r/5443/#comment8235>

    Why is the only change to this line, the addition of spaces inside (), which is actually against the kdelibs coding style? Yes the file was probably not consistent before, but the right direction to go is to remove these spaces in the code you touch, not to add them ;)
    
    http://techbase.kde.org/Policies/Kdelibs_Coding_Style


- David


On 2010-10-05 17:05:06, Steven Sroka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5443/
> -----------------------------------------------------------
> 
> (Updated 2010-10-05 17:05:06)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This is my first submission to KDE. If I am missing something, don't hesitate to tell me.
> 
> This is a slight GUI change to the rename/overwrite dialog window, just to make it more user friendly.
> 
> 
> This addresses bug 238942.
>     https://bugs.kde.org/show_bug.cgi?id=238942
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kio/kio/renamedialog.h 1181964 
>   /trunk/KDE/kdelibs/kio/kio/renamedialog.cpp 1181964 
> 
> Diff: http://svn.reviewboard.kde.org/r/5443/diff
> 
> 
> Testing
> -------
> 
> Correctly Compiled.
> "Eye ball'ed" Code.
> Ran code with all possible '_mode' as per http://api.kde.org/4.5-api/kdelibs-apidocs/kio/html/namespaceKIO.html#bac5df6792cd3426582dbfd1af706bff
> Ran many possible combinations (most if not all) -> move folder to folder, file to file, file to folder, folder to file, and paid attention to creation date.
> 
> (I actually found a bug with the preview picture that is shown in a certain scenario - I will create a bug notice for it on bugs.kde.org soon)
> 
> 
> Screenshots
> -----------
> 
> KDE Trunk - Folder to Folder
>   http://svn.reviewboard.kde.org/r/5443/s/524/
> *New - Folder to Folder
>   http://svn.reviewboard.kde.org/r/5443/s/525/
> KDE Trunk - Bug
>   http://svn.reviewboard.kde.org/r/5443/s/526/
> *New - File to File
>   http://svn.reviewboard.kde.org/r/5443/s/527/
> KDE 4.5 - File to File
>   http://svn.reviewboard.kde.org/r/5443/s/528/
> Revision 5 Screenshot
>   http://svn.reviewboard.kde.org/r/5443/s/529/
> 
> 
> Thanks,
> 
> Steven
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101005/7f728465/attachment.htm>