Review Request: Minor GUI change to rename/overwrite dialog window

[Steven Sroka]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5443/
-----------------------------------------------------------

(Updated 2010-10-03 01:05:48.919374)


Review request for kdelibs.


Changes
-------

Screenshot#5 - This is how small the file preview icon should be.

I'm strictly speaking of the text file image and not all the grey space around it. They wasted space was something I knew from the beginning I had to get rid of.


Summary
-------

This is my first submission to KDE. If I am missing something, don't hesitate to tell me.

This is a slight GUI change to the rename/overwrite dialog window, just to make it more user friendly.


This addresses bug 238942.
    https://bugs.kde.org/show_bug.cgi?id=238942


Diffs
-----

  /trunk/KDE/kdelibs/kio/kio/renamedialog.cpp 1179201 

Diff: http://svn.reviewboard.kde.org/r/5443/diff


Testing
-------

Correctly Compiled.
"Eye ball'ed" Code.
Ran code with all possible '_mode' as per http://api.kde.org/4.5-api/kdelibs-apidocs/kio/html/namespaceKIO.html#bac5df6792cd3426582dbfd1af706bff
Ran many possible combinations (most if not all) -> move folder to folder, file to file, file to folder, folder to file, and paid attention to creation date.

(I actually found a bug with the preview picture that is shown in a certain scenario - I will create a bug notice for it on bugs.kde.org soon)


Screenshots
-----------

KDE Trunk - Folder to Folder
  http://svn.reviewboard.kde.org/r/5443/s/524/
*New - Folder to Folder
  http://svn.reviewboard.kde.org/r/5443/s/525/
KDE Trunk - Bug
  http://svn.reviewboard.kde.org/r/5443/s/526/
*New - File to File
  http://svn.reviewboard.kde.org/r/5443/s/527/
KDE 4.5 - File to File
  http://svn.reviewboard.kde.org/r/5443/s/528/


Thanks,

Steven

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101003/2a613c5c/attachment.htm>