Review Request: Minor GUI change to rename/overwrite dialog window

Steven Sroka thedude_10160 at
Sun Oct 3 01:56:46 BST 2010

This is an automatically generated e-mail. To reply, visit:

(Updated 2010-10-03 00:56:46.498158)

Review request for kdelibs.


This is the bug I found. Some code that set up the preview for the source was copied and used to create the preview for the destination, hence why the destination container (which should show a text file icon) is actually showing a folder icon, and nothing is shown for the source preview.


This is my first submission to KDE. If I am missing something, don't hesitate to tell me.

This is a slight GUI change to the rename/overwrite dialog window, just to make it more user friendly.

This addresses bug 238942.


  /trunk/KDE/kdelibs/kio/kio/renamedialog.cpp 1179201 



Correctly Compiled.
"Eye ball'ed" Code.
Ran code with all possible '_mode' as per
Ran many possible combinations (most if not all) -> move folder to folder, file to file, file to folder, folder to file, and paid attention to creation date.

(I actually found a bug with the preview picture that is shown in a certain scenario - I will create a bug notice for it on soon)


KDE Trunk - Folder to Folder
*New - Folder to Folder
KDE Trunk - Bug



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list