Review Request: Adds method to KBookmarkManager disable showing dialogs on errors.

[Matthias Fuchs]

> On 2010-11-29 00:08:22, Albert Astals Cid wrote:
> > Why did you change the if/else logic? Also you added another kError when there was an existing one already.
> > 
> > Also as commented on IRC maybe it would make sense to emit a signal to warn whoever might be interested that an error happened
> 
> Matthias Fuchs wrote:
>     I changed that to always have a useful debug output. The second one is there to make it easier if there are bug reports, as it is hard to work with translated messages, especially if they are quite important. So not the whole message is translated, probably I should us an error code there, as file.errorString() is translated.

Btw. on the signal.

Should it just be an "void error()" signal or a "void error(translatedErrorMessage)" one?


- Matthias


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6004/#review9034
-----------------------------------------------------------


On 2010-11-28 21:00:30, Matthias Fuchs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6004/
> -----------------------------------------------------------
> 
> (Updated 2010-11-28 21:00:30)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Summary
> -------
> 
> Adds method to KBookmarkManager disable showing dialogs on errors.
> This way it is possible to deactivate those messages if KBoomarkManager is not run in the gui thread.
> BUG:207592
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmanager.h 1201809 
>   /trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmanager.cc 1201809 
> 
> Diff: http://svn.reviewboard.kde.org/r/6004/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matthias
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101130/d6c33711/attachment.htm>