Review Request: Merge changes from ffmpethumbnail projekt into the kde version

Thomas L├╝bking thomas.luebking at gmail.com
Mon Nov 22 21:32:05 GMT 2010



> On 2010-11-22 21:10:52, Christoph Feck wrote:
> > Wouldn't it be much simpler to use a scaled QPainter on the QImage to render the filmstrip holes at different sizes?

... besides that the (hard)code(d strips - at least form a glimpse on the diff) does not look endian safe - iff we still care about IBM/Motorola architectures (no idea what's required for bi-enders like ARM in this regard)


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5937/#review8904
-----------------------------------------------------------


On 2010-11-22 20:16:46, Andreas Scherf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5937/
> -----------------------------------------------------------
> 
> (Updated 2010-11-22 20:16:46)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> + Some type changes (uinXX to quintXX), some code cleanup and some compile fixes.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdemultimedia/CMakeLists.txt 1199813 
>   trunk/KDE/kdemultimedia/cmake/modules/FindFFMPEG.cmake PRE-CREATION 
>   trunk/KDE/kdemultimedia/ffmpegthumbs/CMakeLists.txt 1199813 
>   trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/ChangeLog 1199813 
>   trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/filmstrip.h PRE-CREATION 
>   trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/filmstripfilter.cpp 1199813 
>   trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/moviedecoder.h 1199813 
>   trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/moviedecoder.cpp 1199813 
>   trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/videoframe.h 1199813 
>   trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/videothumbnailer.h 1199813 
> 
> Diff: http://svn.reviewboard.kde.org/r/5937/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101122/5d81c16e/attachment.htm>


More information about the kde-core-devel mailing list