Review Request: Add isReleased() method to StorageDrive interface

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5770/#review8545
-----------------------------------------------------------



trunk/KDE/kdelibs/solid/solid/storagedrive.h
<http://svn.reviewboard.kde.org/r/5770/#comment8918>

    The extra whitespace at the end of the line shall be removed.



trunk/KDE/kdelibs/solid/solid/storagedrive.h
<http://svn.reviewboard.kde.org/r/5770/#comment8919>

    The extra whitespace at the end of the line shall be removed.



trunk/KDE/kdelibs/solid/solid/storagedrive.h
<http://svn.reviewboard.kde.org/r/5770/#comment8920>

    The extra whitespace at the end of the line shall be removed.



trunk/KDE/kdelibs/solid/solid/storagedrive.h
<http://svn.reviewboard.kde.org/r/5770/#comment8922>

    You forgot to add a "released" read-only property in StorageDrive.
    
    Also, I'm still not sold on the isReleased name (IIRC from our discussions I mentionned it'd probably be only temporary). I'm afraid it can be very ambiguous (just like the alternative I've in mind: "isUnused").
    
    It'd be nice if one of our native speakers around could take a look at that ASAP...



trunk/KDE/kdelibs/solid/solid/storagedrive.cpp
<http://svn.reviewboard.kde.org/r/5770/#comment8921>

    listFromQuery has a second optional parameter to specify the parentUdi to restrict the query. Would avoid part of the check in the loop below.


- Kevin


On 2010-11-04 22:59:42, Jacopo De Simoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5770/
> -----------------------------------------------------------
> 
> (Updated 2010-11-04 22:59:42)
> 
> 
> Review request for kdelibs and Kevin Ottens.
> 
> 
> Summary
> -------
> 
> This patch adds a isReleased() method in the StorageDrive interface. 
> The usecase for this are applications that need to know if it is possible to safely unplug a device by checking the isReleased() property on the parent drive. 
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/solid/solid/storagedrive.h 1193078 
>   trunk/KDE/kdelibs/solid/solid/storagedrive.cpp 1193078 
> 
> Diff: http://svn.reviewboard.kde.org/r/5770/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jacopo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101108/6e1554a6/attachment.htm>