Review Request: Add DevicePrivate pointer to DeviceInterfacePrivate

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5769/#review8544
-----------------------------------------------------------

Ship it!


Please adjust DeviceInterfacePrivate ctor as indicated below, then commit.


trunk/KDE/kdelibs/solid/solid/deviceinterface_p.h
<http://svn.reviewboard.kde.org/r/5769/#comment8917>

    This pointer has to be initialized to 0 in DeviceInterfacePrivate ctor. It's missing right now.


- Kevin


On 2010-11-04 22:51:55, Jacopo De Simoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5769/
> -----------------------------------------------------------
> 
> (Updated 2010-11-04 22:51:55)
> 
> 
> Review request for kdelibs and Kevin Ottens.
> 
> 
> Summary
> -------
> 
> This patch adds a DevicePrivate pointer to the private class DeviceInterfacePrivate.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/solid/solid/device.cpp 1193078 
>   trunk/KDE/kdelibs/solid/solid/deviceinterface.cpp 1193078 
>   trunk/KDE/kdelibs/solid/solid/deviceinterface_p.h 1193078 
> 
> Diff: http://svn.reviewboard.kde.org/r/5769/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jacopo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101108/e6c7053c/attachment.htm>