Review Request: Four simple patches for kdecore

[Albert Astals Cid]

> On 2010-11-07 02:06:16, Dawit Alemayehu wrote:
> > /trunk/KDE/kdelibs/kdecore/localization/klocale_kde.cpp, line 2699
> > <http://svn.reviewboard.kde.org/r/5775/diff/2/?file=40688#file40688line2699>
> >
> >     The iterators here should be changed to constBegin() and constEnd(). Actually, there are many places in kdelibs that could benefit from such change as well... Without including the cases of non-const iterators, I get 185 hits when i execute the command below in kdelibs:
> >     
> >     find -name "*.cpp" -exec grep --color -Hn "for" {} \; | grep "constEnd" | wc -l
> >     
> >

FWIW i disagree with changing perfectly valid ::begin to ::constBegin (that is when the container is already const)


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5775/#review8527
-----------------------------------------------------------


On 2010-11-06 22:35:06, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5775/
> -----------------------------------------------------------
> 
> (Updated 2010-11-06 22:35:06)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> As I do not know if that kind of patches are allowed in the freeze period, I ask for them together. I'll submit them individually.
> 
> 1. ktimezone.   Include a comment with the real use of refCount.
> 2. klocale_kde. From 469 queries to paths.end() to 1 (from 0.01% to 0% in callgrind)
> 3. netsupp.     Remove a memory leak.
> 4. ksharedDataCache. Change the obsolete usleep (since 2001 or before) to nanosleep.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdecore/date/ktimezone.cpp 1193582 
>   /trunk/KDE/kdelibs/kdecore/localization/klocale_kde.cpp 1193582 
>   /trunk/KDE/kdelibs/kdecore/network/netsupp.cpp 1193582 
>   /trunk/KDE/kdelibs/kdecore/util/kshareddatacache.cpp 1193582 
> 
> Diff: http://svn.reviewboard.kde.org/r/5775/diff
> 
> 
> Testing
> -------
> 
> No regressions in the unit tests.
> Working with them.
> 
> 
> Thanks,
> 
> Jaime
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101107/f788b1ba/attachment.htm>