Review Request: Four simple patches for kdecore

[David Jarvie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5775/#review8523
-----------------------------------------------------------



/trunk/KDE/kdelibs/kdecore/date/ktimezone.cpp
<http://svn.reviewboard.kde.org/r/5775/#comment8884>

    The patch is wrong. 'refCount' holds the number of KTimeZoneBackend instances use the KTimeZonePrivate instance as a d-pointer. Changing the contents of a KTimeZonePrivate instance by means of operator=() doesn't affect how many references to it are held, so refCount must remain unchanged.


- David


On 2010-11-06 13:01:55, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5775/
> -----------------------------------------------------------
> 
> (Updated 2010-11-06 13:01:55)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> As I do not know if that kind of patches are allowed in the freeze period, I ask for them together. I'll submit them individually.
> 
> 1. ktimezone.   Include the initialization of refcount in the = operator.
> 2. klocale_kde. From 469 queries to paths.end() to 1 (from 0.01% to 0% in callgrind)
> 3. netsupp.     Remove a memory leak.
> 4. ksharedDataCache. Change the obsolete usleep (since 2001 or before) to nanosleep.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdecore/date/ktimezone.cpp 1193582 
>   /trunk/KDE/kdelibs/kdecore/localization/klocale_kde.cpp 1193582 
>   /trunk/KDE/kdelibs/kdecore/network/netsupp.cpp 1193582 
>   /trunk/KDE/kdelibs/kdecore/util/kshareddatacache.cpp 1193582 
> 
> Diff: http://svn.reviewboard.kde.org/r/5775/diff
> 
> 
> Testing
> -------
> 
> No regressions in the unit tests.
> Working with them.
> 
> 
> Thanks,
> 
> Jaime
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101106/49efbe44/attachment.htm>