Solid upower backend and kdeinit crash...

[Kevin Ottens]

Hello,

Adding kde-hardware-devel in CC, as that's likely where the authors of that 
code are hiding. ;-)

Cheers.


On Friday 29 October 2010 19:48:49 Dawit A wrote:
> Hi,
> 
> The upower backend, more specifically the XRandrBrightness class,
> causes kdeinit to crash on my system when you come back from screen
> lock mode. This happens because when the check for the backlight
> property fails in the constructor of XRandrBrightness, which happens
> on my system, it returns immediately. That leaves the m_resources
> variable set to NULL. Unfortunately both the brightness and
> setBrightness member functions use m_resources without even bothering
> to check whether it is null or not and hence the crash. Actually, the
> call to XRandrBrightness::brightness can be traced one step back to
> PowerDevilUPowerBackend::brightness which also does not bother to
> check whether the action it wants to obtain is supported or not before
> calling it, i.e. it does not do  XRandrBrightness::isSupported...
> 
> Anyhow, the issue can be fixed in a couple of ways, not returning when
> backlight check fails in ctor or checking validity of the m_resources
> pointer before using it. Not sure which would be the correct fix
> though. Any ideas ?

-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud patron of KDE, http://www.kdab.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101102/918329e9/attachment.sig>