Review Request: Avoid setting a style that is already set
Albert Astals Cid
aacid at kde.org
Sat May 29 21:28:40 BST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4178/
-----------------------------------------------------------
Review request for kdelibs and Olivier Goffart.
Summary
-------
Qt is not smart enough not to avoid loading a style that is already set. This avoids a unneeded creation and deletion of the current style for me. It works for all styles since QStyleFactory::create does
if(ret)
ret->setObjectName(style);
Diffs
-----
trunk/KDE/kdebase/workspace/qguiplatformplugin_kde/qguiplatformplugin_kde.cpp 1132095
Diff: http://reviewboard.kde.org/r/4178/diff
Testing
-------
Started an app, it worked, Oxygen destructor was not called like it was before
Thanks,
Albert
More information about the kde-core-devel
mailing list