HAVE_XTEST in keyboard kcm module

Andriy Rysin arysin at gmail.com
Mon May 24 19:06:07 BST 2010

On May 24, 2010, at 5:36, Lubos Lunak <l.lunak at suse.cz> wrote:

> On Sunday 23 of May 2010, Andriy Rysin wrote:
>> It looks like we have some code within HAVE_XTEST (as an  
>> anternative to
>> HAVE_XKB) in keyboard kcm module (keyboard_hardware.cpp) but the  
>> whole
>> module won't be even compiled if XKB not found (kcontrol/ 
>> CMakeLists.txt -
>> and it was like this since 4.0).
>> The comments around that code have Lubos and Oswald mentioned so this
>> question might be more to them than anybody else: do we have a  
>> reason to
>> have XTEST code (and then we need some redesign as keyboard module  
>> now
>> includes both hardware and layouts) or we can just rely on XKB?
> The XTest code had been written before the Xkb code, and it was left  
> there as
> a fallback in case a system would have only XTest and not Xkb.  
> According to
> http://en.wikipedia.org/wiki/X_Window_System there is a chance such  
> a system
> exists, but it shouldn't be a strong reason in case there is a  
> problem with
> keeping the code.
Well there's no problem keeping the code (as it's never compiled  
anyway), though some time has to invested if we were to use it :)
I'll keep it for now and see if anybody requests this functionality...


More information about the kde-core-devel mailing list