Review Request: Properly hide KConfigDialog page headers when there is no header text set

Ignat Semenov ragnarokk91 at
Mon May 24 17:55:36 BST 2010

This is an automatically generated e-mail. To reply, visit:

(Updated 2010-05-24 16:55:36.267182)

Review request for kdelibs and Plasma.


This is essentially a workaround for the broken logic in KPageWidgetItem::setHeader(). When no header text was supplied in KConfigDialog::addPage(), a KPageWidgetItem was created with QString() as the header text, which caused the header to be set, as setHeader checks for header.isNull() and thus requires a QString(""). This patch makes sure that when header==QString() in addPage, setHeader( QString("") ) is called.


  /trunk/KDE/kdelibs/kdeui/dialogs/kconfigdialog.cpp 1130107 



After applying the patch, no headers appear in the Plasma configuration dialogs, which use KConfigDialog::addPage(QWidget *, QString &, QString &).
It doesn't break BC as the cnahge is done in a private class.



More information about the kde-core-devel mailing list