Review Request: Make KUriFilter viable for apps that only want to do search filtering...

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4040/
-----------------------------------------------------------

(Updated 2010-05-21 04:19:01.772424)


Review request for kdelibs and Aaron Seigo.


Changes
-------

Patch updated to include the following functionality:

- Added the ability to query for the icons associated with the preferred search providers.
- Added set/get function to specify alternate search providers in cases where the user has not
   selected either a default search engine or a list of favorite search engines. 

These two additional capabilities should be the last ones needed to change every code to use KURIFilter instead reading the configuration files of the search uri filter plugins...


Summary (updated)
-------

The attached patch adds functionality to KUriFilter and its helper classes to make it possible to use it for only search related filtering. The intent of this patch is to correctly address the issue that caused applications/plugins to write their own implementation of web shortcut filters because of missing functionality in this class. This has led to behavioral differences between implementations, e.g. Konqueror's location bar vs KRunner. 

For further discussion of the issues, please refer to the following thread:

http://lists.kde.org/?t=127370544600008&r=1&w=2


With this enhacement, KRunner can now obtain information it needs to show the user feedback such as "Search <provider-name> for <search-term>" where both <provider-name> and <search-term> are now made available by KUriFilterData. The enhancement also allows khtml and kwebkitpart to query for all the necessary information they need to display context menu "search" options on selected text instead of relying on the configuration information of a completely unrelated application (read: plugin) which can definitely be changed without notice!


Diffs (updated)
-----

  trunk/KDE/kdelibs/kio/kio/kurifilter.h 1128997 
  trunk/KDE/kdelibs/kio/kio/kurifilter.cpp 1128997 
  trunk/KDE/kdebase/runtime/kurifilter-plugins/ikws/kurisearchfilter.cpp 1128998 
  trunk/KDE/kdebase/runtime/kurifilter-plugins/ikws/kurisearchfilter.h 1128998 
  trunk/KDE/kdebase/runtime/kurifilter-plugins/ikws/kuriikwsfiltereng.cpp 1128998 
  trunk/KDE/kdebase/runtime/kurifilter-plugins/ikws/kuriikwsfiltereng.h 1128998 
  trunk/KDE/kdebase/runtime/kurifilter-plugins/ikws/kuriikwsfilter.cpp 1128998 

Diff: http://reviewboard.kde.org/r/4040/diff


Testing
-------


Thanks,

Dawit