Review Request: Fix vertical positionning of "click" message in klineedit
Hugo Pereira Da Costa
hugo at oxygen-icons.org
Thu May 20 23:35:00 BST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4042/
-----------------------------------------------------------
(Updated 2010-05-20 22:34:59.816828)
Review request for kdelibs.
Changes
-------
Implemented suggestion 1 and 2.
Summary
-------
This patch makes a better job at painting klineEdit 'click' message (e.g. in systemsettings 'search' bar) in a way that is similar to what qlineedit::paintEvent does for normal text.
This notably fixes the vertical alignment of the "click" message for some styles, including oxygen (see attached screenshot)
Diffs (updated)
-----
/trunk/KDE/kdelibs/kdeui/widgets/klineedit.cpp 1128996
Diff: http://reviewboard.kde.org/r/4042/diff
Testing
-------
Tested with oxygen, plastique, skulpture, and bespin. It was checked that the "click message" is vertically positioned the same as normal text (from user input) is, with all styles
Screenshots
-----------
vertically centered "click" message in systemsettings
http://reviewboard.kde.org/r/4042/s/399/
Thanks,
Hugo
More information about the kde-core-devel
mailing list