Review Request: Load KDE Resource Restrictions from Kiosk profiles

[Dario Freddi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4059/#review5766
-----------------------------------------------------------


Commenting just for the KAuth part.
P.S.: Watch out for whitespaces, there are many!


/trunk/KDE/kdelibs/kdecore/auth/backends/mac/AuthServicesBackend.cpp
<http://reviewboard.kde.org/r/4059/#comment5411>

    This part is completely unneeded: Action::status() already returns Invalid if the action is not valid. After my recent changes, the action is considered invalid if the action does not exist, so this code is redundant and should be removed.



/trunk/KDE/kdelibs/kdecore/auth/backends/polkit-1/Polkit1Backend.cpp
<http://reviewboard.kde.org/r/4059/#comment5405>

    Whitespace



/trunk/KDE/kdelibs/kdecore/auth/backends/polkit-1/Polkit1Backend.cpp
<http://reviewboard.kde.org/r/4059/#comment5412>

    This one instead still might make sense - even as I already told you it will never happen.



/trunk/KDE/kdelibs/kdecore/auth/backends/polkit-1/Polkit1Backend.cpp
<http://reviewboard.kde.org/r/4059/#comment5406>

    Coding style: switch (r) { - if (bla) { - } else {
    Also, if possible remove the { } from the case:


- Dario


On 2010-05-20 04:36:49, Petr Mrázek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4059/
> -----------------------------------------------------------
> 
> (Updated 2010-05-20 04:36:49)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Kiosk restrictions on resources couldn't be specified in the Kiosk profiles before. This should fix that.
> I also cleaned up some other related bits and moved the check for resource restrictions into KAuthorized.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdecore/CMakeLists.txt 1125109 
>   /trunk/KDE/kdelibs/kdecore/auth/backends/fake/FakeBackend.cpp 1125109 
>   /trunk/KDE/kdelibs/kdecore/auth/backends/mac/AuthServicesBackend.cpp 1125109 
>   /trunk/KDE/kdelibs/kdecore/auth/backends/policykit/PolicyKitBackend.cpp 1125109 
>   /trunk/KDE/kdelibs/kdecore/auth/backends/polkit-1/Polkit1Backend.cpp 1125767 
>   /trunk/KDE/kdelibs/kdecore/kernel/kauthorized.h 1125109 
>   /trunk/KDE/kdelibs/kdecore/kernel/kauthorized.cpp 1125109 
>   /trunk/KDE/kdelibs/kdecore/kernel/kcomponentdata.cpp 1125109 
>   /trunk/KDE/kdelibs/kdecore/kernel/kstandarddirs.h 1125109 
>   /trunk/KDE/kdelibs/kdecore/kernel/kstandarddirs.cpp 1125109 
> 
> Diff: http://reviewboard.kde.org/r/4059/diff
> 
> 
> Testing
> -------
> 
> I've made a user profile, assigned it to a dummy user and restricted the wallpaper resource in that profile's kdeglobals config file. It works as expected -- user owned wallpapers aren't listed in desktop activity settings.
> Same kind of test done with the 'config' resource reveals other problems. For example plasma-desktop does indeed respect the restriction,
> but KDE's color settings seem to be still loaded from the user's configuration files.
> 
> 
> Thanks,
> 
> Petr
> 
>