Review Request: Use KPluginFactory in KFindDialog to load kregexpeditor dialog

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4077/#review5763
-----------------------------------------------------------


Sorry, I have no idea if the code is good, but one question: Is it okay to remove the "regexpDialogQueryDone = true;" line?

- Christoph


On 2010-05-20 17:35:38, Jean-Baptiste Rouault wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4077/
> -----------------------------------------------------------
> 
> (Updated 2010-05-20 17:35:38)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Summary
> -------
> 
> In commit 1128695 I ported kregexpeditor to K_PLUGIN_FACTORY.
> This patch change the code in KFindDialog so that it can load kregexpeditor dialog again.
> I don't know if it's the good way to do it, but KServiceTypeTrader::createInstanceFromQuery()
> returns with the error "No service matching the requirements was found"
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/findreplace/kfinddialog.cpp 1128687 
> 
> Diff: http://reviewboard.kde.org/r/4077/diff
> 
> 
> Testing
> -------
> 
> Tested in konqueror by using the search dialog in a <textarea>
> 
> 
> Thanks,
> 
> Jean-Baptiste
> 
>