Review Request: Correct KDE's globalpath (XDG) handling

[Matthias Fuchs]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4002/
-----------------------------------------------------------

Review request for kdelibs and David Faure.


Summary
-------

The KDE paths KCM stores two quote-signs for xdg-user-dirs [1] when the line is empty. This is wrong behavior according to the spec, as if a xdg-user-dir should be disabled it should be preferable changed to point to $HOME or alternatively the line should be deleted.

E.g.
Currently:
XDG_DOWNLOAD_DIR=""
With the patch:
XDG_DOWNLOAD_DIR="$HOME/"

Currently if the line is empty in the KCM user dirs are set to two quotes which is not a directory. In the case of the Download path an "/" is appended leading to downloadPath pointing to the root directory which is clearly wrong, this patch also fixes the behavior for downloadPath behavior.

[1] located at $HOME/.config/user-dirs.dirs


Diffs
-----

  /trunk/KDE/kdebase/workspace/kcontrol/desktoppaths/globalpaths.cpp 1127714 
  /trunk/KDE/kdelibs/kdeui/kernel/kglobalsettings.cpp 1127714 

Diff: http://reviewboard.kde.org/r/4002/diff


Testing
-------

Tested with trunk. An adapted version (globalpaths.cpp is at a different location) has been tested with the 4.4 branch.


Thanks,

Matthias